4Site
Support Request System
View Patch #40.027.006
Description
Patch ID:
Date Implemented:
Patch Title:
Patch Type:
Request IDs:
Bug
Enhancement
Other
01576 -
WO doesn't always catch costing to inactive equipment
Symptoms:
1. In WO - if you enter an equipment number in full and that Eq is inactive it doesn't seem to catch it eg. eqid 00963. However if you enter in the same eqid without leading zeroes it does catch it as inactive and displays the error msg. 2. Work Requests (WR and fsWorkRequest) allowed inactive equipment and didn't always check for WO allowed for EQ. Also the buttons in WR were being cut off.
Solution:
1. It actually goes through the same validation code but in the first case it found it 2 times (once as Exact and once as Namelike) so COUNT=2. In the case of the partial eqid it finds it only once (Exact - because it formats it first) so COUNT=1. It did setup the error message in both cases and sets the COUNT = -1 to signal an error. But then when it returns to the caller and the original record count > 1 it sets resets COUNT to 1 so it goes through the 'found' code. This reset then cancels the display of the error. I changed it to only reset COUNT=1 if COUNT <> -1. I also found that in my case there were 2 reasons the eqid wasn't valid yet only the last error was being displayed. I changed it to display all errors. 2. Work Requests (WR) buttons fixed up. Both Work Request programs now passes False to clsEQ/Validate to disallow inactive EQ and True to check whether or not the EQ allows WOs against it.
Browse Patches
Find a Patch
Return to Request System Menu